Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following config will force the
create table
statement for thecountry_codes.csv
file to use atext
type for theid
field.I don't love the idea of adding another arbitrary config to the
seeds
block, but I'm unsure where else we can implement this.I know some folks also want this functionality for models too, but we don't have a good way of overriding column types for
create table as (...)
statements. @cmcarthur really keen to hear your thoughts about all of this.Regarding the code in this PR: I think a lot of it should be ripped out of the adapters. If possible, I'd like to make a
seed
materialization which encodes this logic, then execute the seed nodes as we would any other node. I don't love the amount of business logic in the SeedRunner classTODO: