-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove run_error from tracking code #817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, but looking good to me
dbt/tracking.py
Outdated
project, | ||
args, | ||
result_type, | ||
result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably also want to nix result
here too, right? This would contain the exception that dbt throws if the project is misconfigured. There are a couple of instances where we pass exceptions in around here
@drewbanin i nixed result as well. can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you gave this a spin and confirmed that the events were recorded
test:
returns:
the first event is on development, second is on this branch. the invocations both have null results |
@cmcarthur nice! |
This branch removes the
run_error
field from dbt's tracking code.It uses the new 2-0-0 version of the run_model schema.
Closes #805