Fix thread values #819
Merged
Fix thread values #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hahahaha i love it. @beckjake does that test fail if you comment out the change? if so, |
. nice work!
cmcarthur
approved these changes
Jul 3, 2018
|
Yeah, the test fails without the fix commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #648 by overriding the configured profile information with the command-line arguments. The Project object is the last thing that really knows about both CLI arguments and profiles so this seemed like the best place to override things.
The
do_nothingsql is a bit funny becausepg_sleepreturns a void type so I couldn't justselect pg_sleep(1). I assume there's a better way to do it.