Redshift catalog generation (#831) #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcarthur
approved these changes
Jul 19, 2018
There was a problem hiding this comment.
looks great. I defer to @drewbanin on the correctness of the operation SQL.
beckjake
force-pushed
the
redshift-get-catalog
branch
from
75eb4d5
to
2dbb803
Compare
beckjake
force-pushed
the
redshift-get-catalog
branch
from
2dbb803
to
1490335
Compare
|
I did a bunch of rebasing to cleanup the history, but the code is the same - once tests pass I'll merge this branch in. |
beckjake
force-pushed
the
redshift-get-catalog
branch
from
1490335
to
d70e275
Compare
beckjake
force-pushed
the
redshift-get-catalog
branch
from
d70e275
to
526a449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate catalog + manifest on redshift (including for late-binding views), fixes #831
This also exposed a bug where the get_catalog() method on the adapter doesn't clear its transaction, so I fixed that.