add --port parameter to "dbt docs serve" (#955) #987
Merged
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Sep 7, 2018
| @@ -29,7 +31,7 @@ def run(self): | |||
| ) | |||
|
|
|||
| try: | |||
| webbrowser.open_new_tab('http://127.0.0.1:8080') | |||
| webbrowser.open_new_tab('http://127.0.0.1:{}'.format(port)) | |||
There was a problem hiding this comment.
this is not relevant to this change, but it looks like we serve on 0.0.0.0 but we open 127.0.0.1 in the browser. Is there an appreciable difference between these two addresses? I think that 0.0.0.0 is accessible to others on the network, right?
There was a problem hiding this comment.
You shouldn't access 0.0.0.0 - it's intended as a valid address for listening, and means that all source addresses can access it. 127.0.0.0/8 is reserved for loopback adapters and by default 127.0.0.1 is generally bound to a default loopback adapter on every OS, with a hosts file entry of 'localhost' pointing to it.
drewbanin
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--portparameter to "dbt docs serve" that defaults to 8080.FIxes #955.