Fix table/schema quoting on drop, truncate, and rename (#983) #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
fix/drop-table-quoting
branch
from
dc2d453
to
99a04e9
Compare
drewbanin
reviewed
Sep 11, 2018
dbt/adapters/default/impl.py
Outdated
| @classmethod | ||
| def _quote_policy(cls, project_cfg): | ||
| quoting_cfg = project_cfg.get('quoting', {}) | ||
| for quote_key in ('dtabase', 'schema', 'identifier'): |
There was a problem hiding this comment.
should this be database?
There was a problem hiding this comment.
do we need to account for project here too?
There was a problem hiding this comment.
also, I'm pretty confused about cls.DEFAULT_QUOTE. Why would we use that instead of the default quote policy on a given Relation class?
There was a problem hiding this comment.
I didn't really realize how that worked, I've moved it to use that instead.
|
@beckjake looks good! I'm shocked this code change was required -- did we just never account for this? @cmcarthur do you remember if there's a reason we never implemented quoting configs here? How did it ever work?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy adapter
drop,truncate, andrenamecalls were not using the project quoting policy when creating relations to be passed on to their*_relation, so they always became whatever the default was.Fixes #983