Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad handshake for servers using wss. #17

Open
wms2537 opened this issue May 27, 2024 · 1 comment
Open

Bad handshake for servers using wss. #17

wms2537 opened this issue May 27, 2024 · 1 comment

Comments

@wms2537
Copy link

wms2537 commented May 27, 2024

I wonder why is the protocol ws being hardcoded. For servers which require wss, it results in a websocket: bad handshake error.

https://github.com/fiskaly/grafana.surrealdb/blob/f1681f35603219b882e10dd76c70aed9ef81d26b/pkg/plugin/datasource.go#L97C2-L97C57

@ppaulweber
Copy link
Member

ppaulweber commented May 28, 2024

@wms2537 thanks for pointing this our, I'll propose a backwards compatible change by allowing in an upcoming change and rollout that you can specify the location property in the following three flavors:

  • <location> which get's pre-fixed and post-fixed to ws://<location>/rpc
  • ws://<location> which get's post-fixed to ws://<location>/rpc
  • wss://<location> which get's post-fixed to wss://<location>/rpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants