Hotfix/timestamp casting #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested review from
fivetran-reneeli and
fivetran-sheringuyen
fivetran-sheringuyen
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
This PR introduces a fix for
redshiftusers who have their timestamps being currently synced astimestamptz. The fix will explicitly cast the timestamp astimestamp without time zoneto allow for downstream date functions to not error out. I did confirm that casting thetimestamptzdate totimestamp without time zonedoes not alter the data but instead changes its interpretation.Does this PR introduce a breaking change?
This will only modify how the relevant timestamp fields are interpreted within
redshiftand will not result in a breaking change.Is this PR in response to a previously created Issue
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
⌚
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.