New config option: Ignore priorities data #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
SteadyGiant
changed the title
|
Updated changelog. Added myself as a contributor. |
fivetran-joemarkiewicz
approved these changes
May 31, 2022
There was a problem hiding this comment.
@Everettttt thanks so much for opening this PR! These PRs from the community are what help us make these packages better! 🏅
I made a few minor edits, but these changes are good to go! I will merge to main and will plan to release these changes, along with the transform PR tomorrow. Thanks again!
Additionally, I have been giving monthly shout outs in our dbt Slack channel. Would you be willing to share your dbt slack name so I can give you a shout out during our next post!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here.
What change(s) does this PR introduce?
Allow user to ignore Priority data. See PR submitted to
fivetran/dbt_jira, linked above.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
The package still includes Priority data by default.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
See PR submitted to
fivetran/dbt_jira, linked above.How did you test the PR changes?
Ran on my local Windows machine against Redshift.
Select which warehouse(s) were used to test the PR