Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent_id field in the field_option table #32

Merged
merged 4 commits into from
Jun 30, 2022

Conversation

sergiisolaa
Copy link
Contributor

Pull Request
Are you a current Fivetran customer?
Sergi Solà - Data Analytics Engineer - Wallbox Chargers

What change(s) does this PR introduce?

Add parent_id field in the field_option table. The field is used when defining custom fields as parent and child custom fields can be created to define some main categories and subcategories.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

It does not introduce a breaking change in the package as we are only introducing one new field in a table, from which no other table depends in the package.

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiisolaa thank you so much for opening this PR! 🏅

The updates you made looked great and worked on my end. I also tested to ensure the new field wouldn't impact the downstream dbt_jira model, and we look good to go!

I did make a few minor edits to your PR to update our hosted documentation with the changes you applied. I also added the new field to our get_field_option_columns macro so users who do not have this field are still able to use the package successfully.

With that, we are good to go and I will approve this PR! Thanks again for this contribution back to the open source package 😄 You can expect the official release later today.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 914311b into fivetran:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants