Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update joins for recharge__subscription_overview.sql #12

Closed
2 of 4 tasks
fivetran-catfritz opened this issue Sep 1, 2023 · 0 comments · Fixed by #13
Closed
2 of 4 tasks

[Feature] Update joins for recharge__subscription_overview.sql #12

fivetran-catfritz opened this issue Sep 1, 2023 · 0 comments · Fixed by #13
Assignees
Labels
priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates

Comments

@fivetran-catfritz
Copy link
Contributor

fivetran-catfritz commented Sep 1, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

The joins of recharge__subscription_overview CTE subscriptions_charges should be simplified since we now know purchase_item_id = subscription_id for subscriptions. Update from:

    from subscriptions
    left join customers_charge_lines
        on customers_charge_lines.customer_id = subscriptions.customer_id
        and customers_charge_lines.address_id = subscriptions.address_id
        and customers_charge_lines.external_product_id_ecommerce = subscriptions.external_product_id_ecommerce

to

    from subscriptions
    left join customers_charge_lines
        on customers_charge_lines.purchase_item_id = subscriptions.subscription_id

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-catfritz fivetran-catfritz self-assigned this Sep 8, 2023
@fivetran-catfritz fivetran-catfritz added priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates labels Sep 8, 2023
@fivetran-catfritz fivetran-catfritz linked a pull request Sep 11, 2023 that will close this issue
18 tasks
This was referenced Sep 11, 2023
@fivetran-catfritz fivetran-catfritz removed a link to a pull request Sep 11, 2023
18 tasks
@fivetran-catfritz fivetran-catfritz linked a pull request Sep 11, 2023 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant