Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stg_stripe__balance_transaction.sql #82

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lord-skinner
Copy link

adding payout_id

Please provide your name and company

Link the issue/feature request which this PR is meant to address

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.

How did you validate the changes introduced within this PR?

Which warehouse did you use to develop these changes?

Did you update the CHANGELOG?

  • Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?

  • Yes
  • No

If you had to summarize this PR in an emoji, which would it be?

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Sep 10, 2024

HI @lord-skinner thanks for opening this PR!

It looks like here you're adding payout_id to the balance transaction staging model. Would you be able to share a bit about the reason for this suggested addition and how you're looking to leverage this field? Would you imagine this field should be included in any downstream models (within dbt_stripe) or is this suggested addition intended only for the staging model?

Additionally, if you would like this to be considered for being incorporated into the main dbt_stripe_source package, would you be able to open a FR on the repo to highlight the reason for this addition and your thoughts around the usability. This way we can properly link this PR to a corresponding issue. Thanks!

@lord-skinner
Copy link
Author

cc: @rohilla-anuj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants