Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Display correct SLA Breach Time in the zendesk__sla_policies model for first and next reply times #142

Closed
1 of 4 tasks
fivetran-joemarkiewicz opened this issue Feb 7, 2024 · 1 comment
Assignees
Labels
error:unforced status:in_progress Currently being worked on type:bug Something is broken or incorrect

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Feb 7, 2024

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Currently the zendesk__sla_policies end model does provide a SLA breach time field. However, it has become apparent that this field is inconsistent when it comes to the first_reply and next_reply SLAs. This is due to the logic pulling the max breach at time for each record pulled through in the intermediate models. What the logic needs to do is identify which record the SLA was breached within and then pull that down for all records so we may persist it to the final model.

Describe alternatives you've considered

As of right now there is no intuitive way to directly generate the breach time from the models.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the type:enhancement New functionality or enhancement label Feb 7, 2024
@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title [Feature] Display SLA Breach Time in the zendesk__sla_policies model [BUG] Display correct SLA Breach Time in the zendesk__sla_policies model for first and next reply times Feb 9, 2024
@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:bug Something is broken or incorrect error:unforced status:in_progress Currently being worked on and removed type:enhancement New functionality or enhancement labels Feb 9, 2024
@fivetran-joemarkiewicz
Copy link
Contributor Author

This has issue should now be addressed in the latest v0.14.0 release of the dbt_zendesk package. As such, closing this out.

Please feel free to reopen or create a new issue if the original issue persists following the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error:unforced status:in_progress Currently being worked on type:bug Something is broken or incorrect
Projects
None yet
Development

No branches or pull requests

1 participant