Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeタグのdatetime属性の値の実装方法を修正 #5452

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

ai-24
Copy link
Contributor

@ai-24 ai-24 commented Aug 29, 2022

Issue

概要

以前取り組んだIssueのdatetime属性値の書き方があまり良くなかったので修正いたしました。

アプリ上の表示に変更はないため、変更前・変更後のスクリーンショットは割愛させていただきます。

@ai-24 ai-24 self-assigned this Aug 29, 2022
@ai-24 ai-24 marked this pull request as ready for review August 29, 2022 07:43
@ai-24 ai-24 requested a review from komagata August 29, 2022 07:43
@ai-24
Copy link
Contributor Author

ai-24 commented Aug 29, 2022

@komagata さん
こちらのレビューをよろしくお願いいたします!

Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます〜!
確認させて頂きました。OKです〜🙆‍♂️

@komagata komagata merged commit 116860a into main Aug 29, 2022
@komagata komagata deleted the feature/fix-how-to-write-datetime-attribute branch August 29, 2022 16:29
@github-actions github-actions bot mentioned this pull request Aug 29, 2022
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants