Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component could prevent updates propagating through render prop #23

Open
tapayne88 opened this issue Apr 5, 2018 · 1 comment
Open

Comments

@tapayne88
Copy link
Contributor

tapayne88 commented Apr 5, 2018

Frustratingly, after reading this blog post https://cdb.reacttraining.com/react-inline-functions-and-performance-bdff784f5578 it looks like the shouldComponentUpdate optimisation I included in #21 will prevent prop changes propagating through to components within the render prop :(

@fkhadra
Copy link
Owner

fkhadra commented Apr 5, 2018

Hey @tapayne88,

Thanks for the information. I'll read the article tonight. I also want to check if the intersection observer api is a good alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants