diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 4c7210ce..274ed361 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,8 +1,8 @@ -**Do you want to request a *feature* or report a *bug*?** +**Do you want to request a _feature_ or report a _bug_?** **What is the current behavior?** -**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:** +**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your [Stackblitz](https://stackblitz.com/edit/react-toastify-getting-started) example below:** **What is the expected behavior?** diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cec41b9a..526baf08 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,7 +1,7 @@ **Before submitting a pull request,** please make sure the following is done: 1. Fork [the repository](https://github.com/fkhadra/react-toastify) and create your branch from `main`. -2. Run `pnpm` in the repository root. +2. Run `pnpm i` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`pnpm test`). 5. Run `pnpm start` to test your changes in the playground. @@ -10,4 +10,6 @@ 8. Format your code with [prettier](https://github.com/prettier/prettier) (`pnpm prettier`). 9. Make sure your code lints (`pnpm lint:fix`). -**Learn more about contributing [here](https://github.com/fkhadra/react-toastify/blob/master/CONTRIBUTING.md)** \ No newline at end of file +For new features, please make sure that there is an issue related to it. + +**Learn more about contributing [here](https://github.com/fkhadra/react-toastify/blob/master/CONTRIBUTING.md)** diff --git a/src/types.ts b/src/types.ts index f789dae0..72109537 100644 --- a/src/types.ts +++ b/src/types.ts @@ -270,6 +270,7 @@ export interface ToastContainerProps extends CommonOptions, Pick