Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align processor architecture #506

Closed
5 tasks
djkhl opened this issue Jan 12, 2024 · 0 comments · Fixed by #583
Closed
5 tasks

Align processor architecture #506

djkhl opened this issue Jan 12, 2024 · 0 comments · Fixed by #583
Assignees
Labels
enhancement New feature or request refactoring only refactoring, no change in behavior

Comments

@djkhl
Copy link
Collaborator

djkhl commented Jan 12, 2024

While working through the Logprep Architecture some inconsistencies in the processors were found. This should be fixed to improve ongoing maintenance and future developments.

Following points should be revised:

  • all processors should use the same functionality to read from the events (e.g get_dotted_field_value method from Helper module)
  • all processors should use the same functionality to write to events (e.g write_to_field method form processor module)
  • all processors should handle missing fields the same way (e.g handle_missing_fields from FieldManager)
  • align return values form Pseudonymizer Predetector and SelectiveExtractor (see refactor code of pseudonymizer, pre_detector and selective_extractor #323)
  • revise processors like clusterer so that they don't have to override the process method
@djkhl djkhl added enhancement New feature or request refactoring only refactoring, no change in behavior labels Jan 12, 2024
@ppcad ppcad linked a pull request May 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring only refactoring, no change in behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants