Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Correct Offsets for Kafka Output #511

Open
ppcad opened this issue Jan 23, 2024 · 0 comments · May be fixed by #516
Open

Ensure Correct Offsets for Kafka Output #511

ppcad opened this issue Jan 23, 2024 · 0 comments · May be fixed by #516
Assignees
Labels
enhancement New feature or request

Comments

@ppcad
Copy link
Collaborator

ppcad commented Jan 23, 2024

The kafka output stores offsets whenever an event is stored.
However, writing into kafka is asynchroneous and there is no feed-back in Logprep if writing was actually successful.
Thus, it can happen that an offset is set before an event was really written into kafka.

It would be desireable if offsets are only set for events that were successfully sent.
Otherwise there is a possibility for data loss.

A possible solution could involve using a callback in the produce method:
https://docs.confluent.io/kafka-clients/python/current/overview.html#asynchronous-writes

@ppcad ppcad added the enhancement New feature or request label Jan 23, 2024
@ppcad ppcad self-assigned this Jan 23, 2024
@ppcad ppcad changed the title Ensure Correct Offset for Kafka Output Ensure Correct Offsets for Kafka Output Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant