Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Use Offset type directly in JoystickAction.update calculations #631

Merged
merged 2 commits into from
Jan 18, 2021
Merged

👌 Use Offset type directly in JoystickAction.update calculations #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b884f9
👌 Use `Offset` type directly in `JoystickAction.update` calculations
lig Jan 15, 2021
17981fe
Merge branch 'master' into 606-improve-joystick-action-update-logic
erickzanardo Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# CHANGELOG

## [next]
- Use `Offset` type directly in `JoystickAction.update` calculations
- Changed `parseAnchor` in `examples/widgets` to throw an exception instead of returning null when it cannot parse an anchor name
- Code improvements and preparing APIs to null-safety
- BaseComponent removes children marked as shouldRemove during update
Expand Down
10 changes: 3 additions & 7 deletions lib/components/joystick/joystick_action.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,11 @@ class JoystickAction {
// Calculate the knob position
final double nextX = dist * cos(_radAngle);
final double nextY = dist * sin(_radAngle);
final Offset nextPoint = Offset(nextX, nextY);
final nextPoint = Offset(nextX, nextY);

if (_rectAction != null) {
final Offset diff = Offset(
_rectBackgroundDirection.center.dx + nextPoint.dx,
_rectBackgroundDirection.center.dy + nextPoint.dy,
) -
_rectAction.center;

final diff =
_rectBackgroundDirection.center + nextPoint - _rectAction.center;
_rectAction = _rectAction.shift(diff);
}

Expand Down