feat: add display for kubernetes resource check #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/display-for-kubernetes-resource-check
branch
from
031ca24
to
c2de846
Compare
moshloop
reviewed
Aug 28, 2024
adityathebe
force-pushed
the
feat/display-for-kubernetes-resource-check
branch
from
c2de846
to
a69d937
Compare
adityathebe
force-pushed
the
feat/display-for-kubernetes-resource-check
branch
from
a69d937
to
be95d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #2086
On the display template of a kubernetes resource check, a new
display: map[string]stringvariable is made available. Thedisplayvariable contains the display output of all of the checks defined within the kubernetes resource check.A default display expression is also added for kubernetes resource check (which I think should probably be added to all the checks).
This expression simply concats
<check name>: <display> | <check name>: <display> ...Example: here's the display of 3 checks