Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit upstream push size to 1 MB (or increase size directive in SaaS and self hosted) #687

Open
yashmehrotra opened this issue Apr 22, 2024 · 4 comments
Open

Limit upstream push size to 1 MB (or increase size directive in SaaS and self hosted) #687

yashmehrotra opened this issue Apr 22, 2024 · 4 comments
Labels
bug Something isn't working
Milestone
Backlog

Comments

@yashmehrotra
Copy link
Member

https://stackoverflow.com/questions/18121227/how-to-avoid-request-entity-too-large-413-error

Getting a lot of

<head><title>413 Request Entity Too Large</title></head>
<body>
<center><h1>413 Request Entity Too Large</h1></center>
<hr><center>nginx</center>
</body>
</html>
@yashmehrotra yashmehrotra added the bug Something isn't working label Apr 22, 2024
@adityathebe
Copy link
Member

@yashmehrotra we have the --upstream-page-size flag on mission control which defaults to 500.
I think we can reduce that for this particular case.

@yashmehrotra
Copy link
Member Author

@adityathebe Could try, we should then reduce the default altogether because we can't ask users to change values for our bugs, maybe 200 or 300 ?

And then add this in FAQ, ie if you get this in logs, try changing the upstream-page-size param

WDYT

@adityathebe
Copy link
Member

I think we should definitely add a size limitation as well because it's hard to find a sweet spot for --upstream-page-size. Just a few configs close to an MB would mean the user would need to bring down the page size significantly and that slows down the majority of configs which are probably very small in size.

@moshloop

@moshloop
Copy link
Member

I think we can also just add nginx.ingress.kubernetes.io/proxy-body-size: 16m to the ingress annotations to increase this limit

@moshloop moshloop added this to the Backlog milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@moshloop @yashmehrotra @adityathebe