Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show crd link, when source is Push #2185

Conversation

mainawycliffe
Copy link
Contributor

Fixes #2184

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
aws-preview ✅ Ready (Inspect) Visit Preview Aug 30, 2024 5:59am
flanksource-ui ✅ Ready (Inspect) Visit Preview Aug 30, 2024 5:59am

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit 4a4b3dc
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/66d15d9f2680b8000859259b
😎 Deploy Preview https://deploy-preview-2185--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit 4a4b3dc
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/66d15d9f8132bc00083d931f
😎 Deploy Preview https://deploy-preview-2185--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit 4a4b3dc
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/66d15d9fda051f0008f813e2
😎 Deploy Preview https://deploy-preview-2185--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mainawycliffe mainawycliffe force-pushed the 2184-In-settings->-topology-If-source-is-Push-CRD-link-should-not-be-shown-it-crashes-and-allow-option-to-delete branch from 97c5f22 to 0e10c39 Compare August 16, 2024 06:49
@moshloop
Copy link
Member

@mainawycliffe There is no save/update options for UI topologies now ?

@moshloop
Copy link
Member

Can we change the link for agent to be RiRobot2Fill Agent

@moshloop
Copy link
Member

@mainawycliffe - It is wrapping, has an underline and it says link instead of Agent

@mainawycliffe mainawycliffe force-pushed the 2184-In-settings->-topology-If-source-is-Push-CRD-link-should-not-be-shown-it-crashes-and-allow-option-to-delete branch from 97ba8c6 to 4a4b3dc Compare August 30, 2024 05:50
@moshloop moshloop merged commit 88a9645 into main Sep 2, 2024
15 of 17 checks passed
@moshloop moshloop deleted the 2184-In-settings->-topology-If-source-is-Push-CRD-link-should-not-be-shown-it-crashes-and-allow-option-to-delete branch September 2, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In settings > topology, If source is Push CRD link should not be shown (it crashes) and allow option to delete
3 participants