Use V2 to get networks #1078
Merged
Use V2 to get networks #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @rajatchopra PTAL |
rajatchopra
approved these changes
Jan 22, 2019
There was a problem hiding this comment.
/lgtm
Can we have the description provided in the PR be included in the main commit message as well (helps with release notes).
@madhanrm Review please? Thanks.
|
ping @madhanrm |
madhanrm
reviewed
Jan 23, 2019
…ing the networks in V1 and then again in V2. This also fixes an issue users are seeing where a network is listed in the query for V1, but then that network is not able to be found in V2.
|
@madhanrm lgty? |
|
/lgtm |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gets HNS networks using V2 schema. This removes the redundancy of getting the networks in V1 and then again in V2.
This also fixes an issue users are seeing where a network is listed in the query for V1, but then that network is not able to be found in V2.
Release Note