From 153e00149d62decebbc76f2499e10cd22d73a534 Mon Sep 17 00:00:00 2001
From: Mikhail Scherba <mikhail.scherba@flant.com>
Date: Tue, 2 Jul 2024 14:12:46 +0300
Subject: [PATCH] update RunModuleWithNewOpenAPISchema

Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
---
 pkg/addon-operator/http_server.go             |  1 -
 pkg/module_manager/models/modules/basic.go    | 16 ++--
 .../models/modules/values_storage.go          | 15 +---
 .../models/modules/values_storage_test.go     | 82 +++++++++++--------
 pkg/module_manager/module_manager.go          | 30 +------
 5 files changed, 60 insertions(+), 84 deletions(-)

diff --git a/pkg/addon-operator/http_server.go b/pkg/addon-operator/http_server.go
index a4618962..d35b7e8d 100644
--- a/pkg/addon-operator/http_server.go
+++ b/pkg/addon-operator/http_server.go
@@ -72,7 +72,6 @@ func (op *AddonOperator) registerDefaultRoutes() {
     <h1>Addon-operator</h1>
     <pre>go tool pprof http://ADDON_OPERATOR_IP:%s/debug/pprof/profile</pre>
     <p>
-      <a href="/graph">graph's pic</a>
       <a href="/discovery">show all possible routes</a>
       <a href="/metrics">prometheus metrics for built-in parameters</a>
       <a href="/metrics/hooks">prometheus metrics for user hooks</a>
diff --git a/pkg/module_manager/models/modules/basic.go b/pkg/module_manager/models/modules/basic.go
index b130559f..14bb0566 100644
--- a/pkg/module_manager/models/modules/basic.go
+++ b/pkg/module_manager/models/modules/basic.go
@@ -126,16 +126,6 @@ func (bm *BasicModule) ResetState() {
 	}
 }
 
-// GetStaticValues returns the module's static values
-func (bm *BasicModule) GetStaticValues() utils.Values {
-	return bm.valuesStorage.getStaticValues()
-}
-
-// ApplyNewStaticValues sets the module's static values and recalculate the resulting values
-func (bm *BasicModule) ApplyNewStaticValues(values utils.Values) error {
-	return bm.valuesStorage.applyNewStaticValues(values)
-}
-
 // RegisterHooks find and registers all module hooks from a filesystem or GoHook Registry
 func (bm *BasicModule) RegisterHooks(logger *log.Entry) ([]*hooks.ModuleHook, error) {
 	if bm.hooks.registered {
@@ -857,10 +847,16 @@ func (bm *BasicModule) GetValuesStorage() *ValuesStorage {
 	return bm.valuesStorage
 }
 
+// GetSchemaStorage returns current schema storage of the basic module
 func (bm *BasicModule) GetSchemaStorage() *validation.SchemaStorage {
 	return bm.valuesStorage.schemaStorage
 }
 
+// ApplyNewSchemaStorage updates schema storage of the basic module
+func (bm *BasicModule) ApplyNewSchemaStorage(schema *validation.SchemaStorage) error {
+	return bm.valuesStorage.applyNewSchemaStorage(schema)
+}
+
 func (bm *BasicModule) Validate() error {
 	valuesKey := utils.ModuleNameToValuesKey(bm.GetName())
 	restoredName := utils.ModuleNameFromValuesKey(valuesKey)
diff --git a/pkg/module_manager/models/modules/values_storage.go b/pkg/module_manager/models/modules/values_storage.go
index 8f8481c9..b36e4bae 100644
--- a/pkg/module_manager/models/modules/values_storage.go
+++ b/pkg/module_manager/models/modules/values_storage.go
@@ -124,18 +124,9 @@ func (vs *ValuesStorage) validateValues(values utils.Values) error {
 	return vs.schemaStorage.ValidateValues(valuesModuleName, validatableValues)
 }
 
-// getStaticValues returns current static values of the module
-func (vs *ValuesStorage) getStaticValues() utils.Values {
-	vs.lock.Lock()
-	defer vs.lock.Unlock()
-	return vs.staticValues
-}
-
-// applyNewStaticValues sets the module's static values and recalculate the resulting values
-func (vs *ValuesStorage) applyNewStaticValues(values utils.Values) error {
-	vs.lock.Lock()
-	defer vs.lock.Unlock()
-	vs.staticValues = values
+// applyNewSchemaStorage sets new schema storage
+func (vs *ValuesStorage) applyNewSchemaStorage(schema *validation.SchemaStorage) error {
+	vs.schemaStorage = schema
 	return vs.calculateResultValues()
 }
 
diff --git a/pkg/module_manager/models/modules/values_storage_test.go b/pkg/module_manager/models/modules/values_storage_test.go
index aa321186..eb93143f 100644
--- a/pkg/module_manager/models/modules/values_storage_test.go
+++ b/pkg/module_manager/models/modules/values_storage_test.go
@@ -8,9 +8,10 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"github.com/flant/addon-operator/pkg/utils"
+	"github.com/flant/addon-operator/pkg/values/validation"
 )
 
-func TestSetConfigValues(t *testing.T) {
+func TestApplyNewSchemaStorage(t *testing.T) {
 	cfg := `
 type: object
 default: {}
@@ -20,14 +21,6 @@ properties:
     type: string
   highAvailability:
     type: boolean
-  modules:
-    additionalProperties: false
-    default: {}
-    type: object
-    properties:
-      publicDomainTemplate:
-        type: string
-        pattern: '^(%s([-a-z0-9]*[a-z0-9])?|[a-z0-9]([-a-z0-9]*)?%s([-a-z0-9]*)?[a-z0-9]|[a-z0-9]([-a-z0-9]*)?%s)(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$'
 `
 
 	vcfg := `
@@ -49,30 +42,37 @@ properties:
 		"xxx": "yyy",
 	}
 
-	st, err := NewValuesStorage("global", initial, []byte(cfg), []byte(vcfg))
+	valuesStorage, err := NewValuesStorage("global", initial, []byte(cfg), []byte(vcfg))
 	require.NoError(t, err)
 
-	configV := utils.Values{
-		"highAvailability": true,
-		"modules": map[string]interface{}{
-			"publicDomainTemplate": "%s.foo.bar",
-		},
-	}
+	newVcfg := `
+x-extend:
+  schema: config-values.yaml
+type: object
+default: {}
+properties:
+  internal:
+    type: object
+    default: {}
+    properties:
+      fooBar:
+        type: string
+        default: bar
+`
+	schemaStorage, err := validation.NewSchemaStorage([]byte(cfg), []byte(newVcfg))
+	require.NoError(t, err)
+
+	err = valuesStorage.applyNewSchemaStorage(schemaStorage)
+	require.NoError(t, err)
 
-	newValues, err := st.GenerateNewConfigValues(configV, true)
-	assert.NoError(t, err)
-	st.SaveConfigValues(newValues)
 	assert.YAMLEq(t, `
-highAvailability: true
-internal:
-    fooBar: baz
-modules:
-    publicDomainTemplate: '%s.foo.bar'
 xxx: yyy
-`, st.GetValues(false).AsString("yaml"))
+internal:
+    fooBar: bar
+`, valuesStorage.GetValues(false).AsString("yaml"))
 }
 
-func TestApplyNewStaticValues(t *testing.T) {
+func TestSetConfigValues(t *testing.T) {
 	cfg := `
 type: object
 default: {}
@@ -82,6 +82,14 @@ properties:
     type: string
   highAvailability:
     type: boolean
+  modules:
+    additionalProperties: false
+    default: {}
+    type: object
+    properties:
+      publicDomainTemplate:
+        type: string
+        pattern: '^(%s([-a-z0-9]*[a-z0-9])?|[a-z0-9]([-a-z0-9]*)?%s([-a-z0-9]*)?[a-z0-9]|[a-z0-9]([-a-z0-9]*)?%s)(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$'
 `
 
 	vcfg := `
@@ -98,6 +106,7 @@ properties:
         type: string
         default: baz
 `
+
 	initial := utils.Values{
 		"xxx": "yyy",
 	}
@@ -105,19 +114,24 @@ properties:
 	st, err := NewValuesStorage("global", initial, []byte(cfg), []byte(vcfg))
 	require.NoError(t, err)
 
-	newStatic := utils.Values{
-		"xxx": "zzz",
+	configV := utils.Values{
+		"highAvailability": true,
+		"modules": map[string]interface{}{
+			"publicDomainTemplate": "%s.foo.bar",
+		},
 	}
 
-	err = st.applyNewStaticValues(newStatic)
-	require.NoError(t, err)
-
-	v := st.GetValues(false)
+	newValues, err := st.GenerateNewConfigValues(configV, true)
+	assert.NoError(t, err)
+	st.SaveConfigValues(newValues)
 	assert.YAMLEq(t, `
+highAvailability: true
 internal:
     fooBar: baz
-xxx: zzz
-`, v.AsString("yaml"))
+modules:
+    publicDomainTemplate: '%s.foo.bar'
+xxx: yyy
+`, st.GetValues(false).AsString("yaml"))
 }
 
 func TestPatchValues(t *testing.T) {
diff --git a/pkg/module_manager/module_manager.go b/pkg/module_manager/module_manager.go
index 6eb20dca..d964edba 100644
--- a/pkg/module_manager/module_manager.go
+++ b/pkg/module_manager/module_manager.go
@@ -926,12 +926,6 @@ func (mm *ModuleManager) UpdateModuleLastErrorAndNotify(module *modules.BasicMod
 
 // PushRunModuleTask pushes moduleRun task for a module into the main queue if there is no such a task for the module
 func (mm *ModuleManager) PushRunModuleTask(moduleName string, doModuleStartup bool) error {
-	// update module's kube config
-	err := mm.UpdateModuleKubeConfig(moduleName)
-	if err != nil {
-		return err
-	}
-
 	// check if there is already moduleRun task in the main queue for the module
 	if queueHasPendingModuleRunTaskWithStartup(mm.dependencies.TaskQueues.GetMain(), moduleName) {
 		return nil
@@ -951,30 +945,13 @@ func (mm *ModuleManager) PushRunModuleTask(moduleName string, doModuleStartup bo
 	return nil
 }
 
-// UpdateModuleKubeConfig updates a module's kube config
-func (mm *ModuleManager) UpdateModuleKubeConfig(moduleName string) error {
-	err := mm.dependencies.KubeConfigManager.UpdateModuleConfig(moduleName)
-	if err != nil {
-		return fmt.Errorf("couldn't update module %s kube config: %w", moduleName, err)
-	}
-
-	mm.dependencies.KubeConfigManager.SafeReadConfig(func(config *config.KubeConfig) {
-		err = mm.ApplyNewKubeConfigValues(config, false)
-	})
-	if err != nil {
-		return fmt.Errorf("couldn't reload kube config: %s", err)
-	}
-
-	return nil
-}
-
 // AreModulesInited returns true if modulemanager's moduleset has already been initialized
 func (mm *ModuleManager) AreModulesInited() bool {
 	return mm.modules.IsInited()
 }
 
-// RunModuleWithNewStaticValues updates the module's values by rebasing them from static values from modulePath directory and pushes RunModuleTask if the module is enabled
-func (mm *ModuleManager) RunModuleWithNewStaticValues(moduleName, moduleSource, modulePath string) error {
+// RunModuleWithNewOpenAPISchema updates the module's OpenAPI schema from modulePath directory and pushes RunModuleTask if the module is enabled
+func (mm *ModuleManager) RunModuleWithNewOpenAPISchema(moduleName, moduleSource, modulePath string) error {
 	currentModule := mm.modules.Get(moduleName)
 	if currentModule == nil {
 		return fmt.Errorf("failed to get basic module - not found")
@@ -985,8 +962,7 @@ func (mm *ModuleManager) RunModuleWithNewStaticValues(moduleName, moduleSource,
 		return err
 	}
 
-	log.Debugf("new static values for %s module: %v", moduleName, basicModule.GetStaticValues())
-	err = currentModule.ApplyNewStaticValues(basicModule.GetStaticValues())
+	err = currentModule.ApplyNewSchemaStorage(basicModule.GetSchemaStorage())
 	if err != nil {
 		return err
 	}