Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .jsx extension instead of .js #1030

Closed
sijad opened this issue Sep 6, 2016 · 4 comments
Closed

Use .jsx extension instead of .js #1030

sijad opened this issue Sep 6, 2016 · 4 comments

Comments

@sijad
Copy link
Contributor

sijad commented Sep 6, 2016

it's not really a problem now with new modern IDE's, but it feel cleaner that way.
also helps with some linters.
@franzliedke
Copy link
Contributor

Any strong opinions anyone?

From my perspective it would be fine. (I don't know about any large disadvantages, but then I don't know much about JSX anyway. Quick research did not turn up any problems.)

If @tobscure gives the go-ahead, I guess a pull request would be welcomed.

@tobyzerner
Copy link
Contributor

Counter-argument: facebook/react#3582 (comment)

@franzliedke
Copy link
Contributor

Makes sense, too. I guess we can close this then?

@luceos
Copy link
Member

luceos commented Sep 22, 2016

Closing due to strong argument.

@luceos luceos closed this as completed Sep 22, 2016
@sijad sijad mentioned this issue Oct 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tobyzerner @franzliedke @luceos @sijad