`Cannot read property 'content' of null` causes timestamp on post to duplicate for a few seconds #1087

dsevillamartin · 2016-12-14T23:48:02Z

Bug report

Version of Flarum: v0.1.0-beta.6 or maybe dev-master (it's Flarum Discuss)
Website URL where the bug is visible: Happens randomly and then restores itself.

Error

Uncaught TypeError: Cannot read property 'content' of null
    at forum-70f79e94.js:652

Additional comments

I sent many posts to https://discuss.flarum.org/d/4458, and from time to time the timestamps on a few posts got duplicated, and then went back to their normal state. It happened three times, and when I checked the console, there were three errors there that were the same. The error itself can be found above.

It seems to be a bug with the composer itself... That position currently has app.composer.component.content(), which I'm guessing that's a Mithril prop and it's clearing the composer's text content.

The text was updated successfully, but these errors were encountered:

dav-is · 2016-12-15T21:31:01Z

That position currently has app.composer.component.content(), which I'm guessing that's a Mithril prop and it's clearing the composer's text content.

This code wouldn't erase the content but get it. For instance,
this.props.foo('bar'); sets foo as bar, while this.props.foo(); returns bar.

dsevillamartin · 2016-12-15T21:35:16Z

@dav-is Oh, true, I forgot how Mithril props work. But still, this means that the JS is trying to get the composer's text after submitting the new post... with what purpose?

dav-is · 2016-12-15T21:42:28Z

The error indicates app.composer.component is null, not the content. Probably should just use app.composer.content() instead.

dsevillamartin · 2016-12-15T21:44:37Z

app.composer.component only exists when the composer is in the DOM, and app.composer.content is undefined. It could probably just do app.composer.component && app.composer.component.content(), to be honest.

tobyzerner · 2016-12-17T07:09:17Z

I believe duplicate timestamps is a complex Mithril diff algorithm bug (unrelated to the composer) and will hopefully be fixed with Mithril 1.0.

@datitisev which line of code is that exactly?

dsevillamartin · 2016-12-17T15:17:01Z

I managed to get the error again, although it is slightly different.

forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)
    (anonymous function) @ forum-70f79e94.js:652

And that line is actually the onunload method in DiscussionPage, when it tries to hide/close the composer if there is content or no content respectively.

My console is getting spammed, I have 600+ errors from this.

forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)(anonymous function) @ forum-70f79e94.js:652
forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)(anonymous function) @ forum-70f79e94.js:652
forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)(anonymous function) @ forum-70f79e94.js:652
forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)(anonymous function) @ forum-70f79e94.js:652
forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)(anonymous function) @ forum-70f79e94.js:652
forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)(anonymous function) @ forum-70f79e94.js:652
forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)(anonymous function) @ forum-70f79e94.js:652
forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)(anonymous function) @ forum-70f79e94.js:652
forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)(anonymous function) @ forum-70f79e94.js:652
forum-70f79e94.js:652 Uncaught TypeError: Cannot read property 'content' of null(…)

Let me try again to see what steps I took to break it.

dsevillamartin · 2016-12-17T15:20:01Z

Ok. Steps to reproduce:

Go to a discussion
Refresh
Click "Write a reply" at the bottom
Don't type anything
Click the back button at the top (the < = menu thingy)
Check console

It doesn't seem to bug out anything anymore, but it does spam the console pretty quickly

kajack · 2019-12-21T20:40:02Z

Is this solved? Because I'm facing this issue.

dsevillamartin · 2019-12-21T21:15:07Z

@kajack Has it just occurred once or can you reproduce the error consistently?

kajack · 2019-12-22T09:55:21Z

@datitisev Everytime I reply a post, it appears. I don't remember but somewhere ended in an endless loop creating over 1k errors of those.

Any way to fix it or debug it?

luceos · 2019-12-22T13:00:49Z

@kajack please post the output of php flarum info and confirm whether the steps to reproduce match with yours or there are differences.

kajack · 2019-12-22T15:39:26Z

Okay, so basically.

Log in the forum.
Enter any post.
Reply with something.
The error appears there in the console.

Flarum core 0.1.0-beta.11.1
PHP version: 7.3.11
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, readline, Reflection, SPL, session, standard, bcmath, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, intl, json, exif, mysqlnd, odbc, PDO, pgsql, Phar, posix, shmop, SimpleXML, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlwriter, xsl, zip, mysqli, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, wddx, xmlreader, xmlrpc, Zend OPcache
+-------------------------------+----------------+--------+
| Flarum Extensions             |                |        |
+-------------------------------+----------------+--------+
| ID                            | Version        | Commit |
+-------------------------------+----------------+--------+
| flarum-approval               | v0.1.0-beta.8  |        |
| flarum-bbcode                 | v0.1.0-beta.8  |        |
| flarum-emoji                  | v0.1.0-beta.10 |        |
| flarum-lang-english           | v0.1.0-beta.11 |        |
| flarum-flags                  | v0.1.0-beta.10 |        |
| flarum-lock                   | v0.1.0-beta.9  |        |
| flarum-markdown               | v0.1.0-beta.10 |        |
| flarum-mentions               | v0.1.0-beta.10 |        |
| flarum-statistics             | v0.1.0-beta.9  |        |
| flarum-sticky                 | v0.1.0-beta.9  |        |
| flarum-subscriptions          | v0.1.0-beta.9  |        |
| flarum-suspend                | v0.1.0-beta.10 |        |
| flarum-tags                   | v0.1.0-beta.11 |        |
| clarkwinkelmann-circle-groups | 0.2.1          |        |
| v17development-seo            | 1.0.2          |        |
| fof-nightmode                 | 0.3.0          |        |
| fof-spamblock                 | 0.2.1          |        |
| fof-gamification              | 0.1.6          |        |
| flagrow-analytics             | 0.8.0          |        |
| flagrow-sitemap               | 0.2.0          |        |
| fof-follow-tags               | 0.3.4          |        |
| flagrow-ads                   | 0.2.4          |        |
| fof-default-group             | 0.1.0          |        |
| fof-links                     | 0.2.1          |        |
| fof-pages                     | 0.2.7          |        |
| maicol07-sso                  | 1.3.2          |        |
| flagrow-upload                | 0.7.1          |        |
| fof-socialprofile             | 0.1.1          |        |
+-------------------------------+----------------+--------+
Base URL: https://forum.moonquill.com
Installation path: /var/app/current
Debug mode: off

franzliedke · 2020-01-03T14:43:23Z

@kajack Thanks for the reproduction info!

@datitisev Strange... how can the component be null in that line when, right before that, we call composingReplyTo which checks that the component is of type ReplyComposer? 🤔

https://github.com/flarum/core/blob/104d3982fe76f7481bbb957b064e0315314ba118/js/src/forum/ForumApplication.js#L126

dsevillamartin · 2020-01-03T14:51:28Z

@franzliedke Uh.... I haven't got the foggiest idea. And this might not be a bug anymore, I'm unable to reproduce with the steps I laid out.

I'll try it with an older beta and the extensions provided in the PHP info above to see if I can reproduce it. It could've always been fixed but an extension may be now causing it with a slightly different stack trace.

franzliedke · 2020-01-03T15:23:07Z

I couldn't find a recent occurrence in our Sentry logs, but that doesn't mean it doesn't happen. 😉

@kajack If it's not too much work, could you try to reproduce it on a) your forum, with all extensions disabled and b) on https://nightly.flarum.site/? That would help a lot!

askvortsov1 · 2020-10-03T04:58:26Z

I can no longer reproduce this, I believe it was solved either in #2161 or in #2255. Feel free to reopen if anyone finds this again

matteocontrini · 2020-10-03T09:11:38Z

@askvortsov1 shouldn't this be added to the beta14 milestone, perhaps? Together with other recently closed issues, actually.

tobyzerner added the type/bug label Dec 17, 2016

franzliedke mentioned this issue Jan 13, 2017

Rewrite JavaScript component layer for Mithril 1.0 #872

Closed

dsevillamartin mentioned this issue May 18, 2017

[js] Uncaught TypeError: Cannot read property 'content' of null #1165

Closed

dsevillamartin mentioned this issue Mar 7, 2018

When replying, the timestamp of the OP appears duplicated for a few seconds #1383

Closed

luceos added the Frontend label Mar 7, 2018

franzliedke removed the Frontend label Jul 21, 2018

tobyzerner mentioned this issue Aug 12, 2018

Post time/date issue #1534

Closed

luceos added the needs-verification label Jan 8, 2020

dsevillamartin mentioned this issue Apr 13, 2020

Reactions and upvotes mess up the timer FriendsOfFlarum/realtimedate#2

Open

askvortsov1 closed this as completed Oct 3, 2020

askvortsov1 added this to the 0.1.0-beta.14 milestone Oct 3, 2020

matteocontrini mentioned this issue Nov 28, 2021

"Write a reply" prompt is duplicated flarum/issue-archive#36

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Cannot read property 'content' of null` causes timestamp on post to duplicate for a few seconds #1087

`Cannot read property 'content' of null` causes timestamp on post to duplicate for a few seconds #1087

dsevillamartin commented Dec 14, 2016 •

edited

Loading

dav-is commented Dec 15, 2016

dsevillamartin commented Dec 15, 2016

dav-is commented Dec 15, 2016

dsevillamartin commented Dec 15, 2016

tobyzerner commented Dec 17, 2016 •

edited

Loading

dsevillamartin commented Dec 17, 2016

dsevillamartin commented Dec 17, 2016

kajack commented Dec 21, 2019

dsevillamartin commented Dec 21, 2019

kajack commented Dec 22, 2019

luceos commented Dec 22, 2019

kajack commented Dec 22, 2019 •

edited by franzliedke

Loading

franzliedke commented Jan 3, 2020

dsevillamartin commented Jan 3, 2020 •

edited

Loading

franzliedke commented Jan 3, 2020

askvortsov1 commented Oct 3, 2020

matteocontrini commented Oct 3, 2020

Cannot read property 'content' of null causes timestamp on post to duplicate for a few seconds #1087

Cannot read property 'content' of null causes timestamp on post to duplicate for a few seconds #1087

Comments

dsevillamartin commented Dec 14, 2016 • edited Loading

Bug report

Error

Additional comments

dav-is commented Dec 15, 2016

dsevillamartin commented Dec 15, 2016

dav-is commented Dec 15, 2016

dsevillamartin commented Dec 15, 2016

tobyzerner commented Dec 17, 2016 • edited Loading

dsevillamartin commented Dec 17, 2016

dsevillamartin commented Dec 17, 2016

kajack commented Dec 21, 2019

dsevillamartin commented Dec 21, 2019

kajack commented Dec 22, 2019

luceos commented Dec 22, 2019

kajack commented Dec 22, 2019 • edited by franzliedke Loading

franzliedke commented Jan 3, 2020

dsevillamartin commented Jan 3, 2020 • edited Loading

franzliedke commented Jan 3, 2020

askvortsov1 commented Oct 3, 2020

matteocontrini commented Oct 3, 2020

`Cannot read property 'content' of null` causes timestamp on post to duplicate for a few seconds #1087

`Cannot read property 'content' of null` causes timestamp on post to duplicate for a few seconds #1087

dsevillamartin commented Dec 14, 2016 •

edited

Loading

tobyzerner commented Dec 17, 2016 •

edited

Loading

kajack commented Dec 22, 2019 •

edited by franzliedke

Loading

dsevillamartin commented Jan 3, 2020 •

edited

Loading