Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable extensions in dual-column view #2153

Closed
raafirivero opened this issue May 8, 2020 · 13 comments
Closed

re-enable extensions in dual-column view #2153

raafirivero opened this issue May 8, 2020 · 13 comments

Comments

@raafirivero
Copy link

Bug Report

Current Behavior
Not able to re-enable extensions within admin if it is in the Right column during dual-column view.

Steps to Reproduce

  • go to Admin screen / Extensions page

  • if extensions listed are in dual-column view, turn an extension off in the right column

  • it will be greyed out and the check box to turn it back on will disappear.

  • resize browser window so that extension list is a single column. all extensions are able to be enabled in this view.
    Expected Behavior

  • all extensions should be able to turn on and off in both views.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • Flarum version: 0.1.0-beta.13
  • Website URL: [localhost testing]
  • Webserver: apache
  • Hosting environment: localhost
  • PHP version: 7.3.16
  • Browser: safari 13.1
Output of "php flarum info", run this in terminal in your Flarum directory.

column-disble

@dsevillamartin
Copy link
Member

I can't reproduce this. Can you check if there are any styles applied that hide the elements? Because they are still taking up the space.

@raafirivero
Copy link
Author

Just checked in Safari, Chrome, and Firefox. Can only reproduce the problem in Safari. (Re-checked Safari with all browser extensions turned off and it still reproduces the problem). Only thing I can see is that toggling the opacity declaration under this rule, it is visible when turned off. If opacity is set to less than 1 then it is completely invisible again in the right column (left column was always ok):

opacity: 0.5;
color: #996679;
}```

@dsevillamartin
Copy link
Member

What's the selector for that CSS rule? @raafirivero. Also, I assume Safari on macOS?

@raafirivero
Copy link
Author

sorry, thought I pasted it above. selector is:
.ExtensionListItem.disabled .ExtensionListItem-title {

@dsevillamartin
Copy link
Member

dsevillamartin commented May 8, 2020

Is this possibly a Safari issue then? Are you on the latest Safari version?

@raafirivero
Copy link
Author

sounds like it - I hadn't checked all browsers when I first reported

@dsevillamartin
Copy link
Member

Not sure if we want to close this - many people have had this issue and we might want a fix for it.

@raafirivero
Copy link
Author

OK - didn't want to clutter actual dev work with browser bugs --

@raafirivero raafirivero reopened this May 8, 2020
@dsevillamartin
Copy link
Member

No problem. Best to find a root cause before closing.

@stale
Copy link

stale bot commented Aug 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

@stale stale bot added the stale Issues that have had over 90 days of inactivity label Aug 6, 2020
@askvortsov1
Copy link
Member

Still want this

@stale stale bot removed the stale Issues that have had over 90 days of inactivity label Aug 16, 2020
@Ralkage

This comment has been minimized.

@askvortsov1
Copy link
Member

No longer applicable as of #2409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants