Activation email doesn't have forum title prefix when re-sent

[clarkwinkelmann]

Bug Report

Current Behavior
The activation email has the [Forum Name] prefix in the subject. But clicking "send activation email again" sends an identical email, without the prefix.

Steps to Reproduce

1. Create new account
2. Ask for new activation email
3. Compare the two emails received

Expected Behavior
The two emails should have identical titles. The missing prefix seems to be an oversight.

Screenshots

Environment

• Flarum version: beta 15

Possible Solution
Add subject prefix by copy-pasting code

Without prefix

https://github.com/flarum/core/blob/f8edc2d827fee47dc78fbb75ee1d3b28580ed11d/src/Api/Controller/SendConfirmationEmailController.php#L85

With prefix

https://github.com/flarum/core/blob/0a6c5217c11e625aab5deec05bf6a6caf31bfa0d/src/User/AccountActivationMailer.php#L66

[matteocontrini]

I think this is better solved through #2193 (PR => #2493).

[askvortsov1]

This was a purposeful change made in #1613, so I don't think we should be so quick to reverse it. Revisiting that discussion, I think we should remove the prefix entirely from #2493, and from the RequestPasswordResetHandler (https://github.com/flarum/core/blob/f8edc2d827fee47dc78fbb75ee1d3b28580ed11d/src/User/Command/RequestPasswordResetHandler.php#L113-L113) in a separate PR.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!