Policies: treat true as allow, and false as deny

[askvortsov1]

Feature Request

I think the new tiered levels of response in the policies system is well worth it, but is also somewhat inconvenient: I have already forgotten to return one of those 2 variables multiple times. Returning a boolean expression is much more than returning boolean expression ? $this->allow() : $this->deny(). Perhaps AbstractPolicy should treat false as $this->deny() and true as $this->allow()?

[SychO9]

I would be in favor, mainly because it would allow us to directly return expressions like before, which is more straightforward and simple, and it just seems to be the way any developer would expect it to be. Also, since we now have the ALLOW and DENY constants, the change would be very simple.

// Before
return $expression;

// Currently
return $expression ? $this->allow() : $this->deny();

[luceos]

if $expression is "foo", the string, your conditional would be treated as true too..

It would make more sense to do an is_boolean($expression) conditional and then return it:

if(is_bool($expression)) {
    return $expression ? $this->allow() : $this->deny();
}

return <the rest>;

[SychO9]

I was referring to a boolean expression :P
something like:

return $actor->hasPermission('perm') && $actor->id === $model->id;