Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing autocomplete attributes to input fields #3019

Closed
davwheat opened this issue Aug 12, 2021 · 1 comment · Fixed by #3088
Closed

Add missing autocomplete attributes to input fields #3019

davwheat opened this issue Aug 12, 2021 · 1 comment · Fixed by #3088
Labels
Good first issue Hacktoberfest type/bug
Milestone
1.2

Comments

@davwheat
Copy link
Member

davwheat commented Aug 12, 2021 •
edited
Loading

Bug Report

Current Behavior
Our username/password inputs are missing autocomplete attribute hints, as recommended by browser vendors.

Steps to Reproduce

  1. Open log in modal
  2. Open DevTools

image

Expected Behavior
Autocomplete attributes should be present
@davwheat davwheat added this to the 1.1 milestone Aug 12, 2021
@askvortsov1 askvortsov1 modified the milestones: 1.1, 1.2 Sep 28, 2021
@odnmalau odnmalau mentioned this issue Oct 1, 2021
Merged
4 tasks
@odnmalau
Copy link
Contributor

odnmalau commented Oct 1, 2021

Hello,

I have created a draft PR #3088, Feel free to have a look and comment on anything that needs to be changed/added.

@SychO9 SychO9 added this to Roadmap Oct 1, 2021
@SychO9 SychO9 moved this from Todo to Done in Roadmap Oct 13, 2021
@SychO9 SychO9 removed this from Roadmap Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Hacktoberfest type/bug
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Add missing autocomplete attributes to input fields odnmalau/core
3 participants
@davwheat @askvortsov1 @odnmalau