-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonical URL remains when navigating between pages #3648
Comments
In a project I'm working on, I've implemented this hack: const oldPushState = window.history.pushState;
window.history.pushState = function (...args) {
oldPushState.call(this, ...args);
document.head.querySelectorAll('link[rel="canonical"]').forEach((link) => {
if (link.getAttribute('href') !== window.location.href) {
link.setAttribute('href', window.location.href);
}
});
document.head.querySelectorAll('link[rel="next"], link[rel="prev"]').forEach((link) => {
link.remove();
});
}; |
I always assumed it was by design. That attribute is only for the initial page load / scrapers, just like if OpenGraph data is added to the page. I'm not sure how we can refresh this kind of data without making an API request that involves the Setting the Removing the tag after the first URL change does seem to make the most sense if it's interfering with JS libraries. Libraries can then fall back to the current browser URL which isn't guaranteed canonical. |
The reason I ran into this issue was that some analytics providers utilise the canonical, if present, instead of the actual URL, like Fathom. I wonder if we should remove it (and rel=prev/next) on navigation, but perhaps an extension could be better placed for updating it (perhaps somehow with a "get canonical" API endpoint?). Not sure about the best approach here. |
Current Behavior
When navigating through the SPA, the canonical found in the page
<head>
remains.E.g., if you visit the forum home page, then navigate to a discussion, the canonical is still the home page URL.
Steps to Reproduce
Self-explanatory
Expected Behavior
Canonical should be updated with a new URL
Screenshots
No response
Environment
Output of
php flarum info
No response
Possible Solution
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: