-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to limit discussion title length #53
Comments
80? |
Yeah 80 sounds good. |
Why not let site admins modify the max title length instead of write it into the source code? (but 80 is still a good length for title) |
One reason that comes to my mind: the limit is probably enforced by database constraints (i.e. the |
what would be the use-case for modifying the title length? adding customization for the sake of having customization adds unnecessary complexity when there is no realistic reasons for modifying it. |
The use case would be a forum admin wanting to increase or decrease the allowed length of forum titles.. While I agree with not adding complexity, searching around on Google provides a lot of results for people looking to customize the title length of different software (vBulletin, phpBB, etc.) Perhaps it's not a priority for initial release, but it certainly is not in the realm of 'unrealistic' to provide some method to change it. |
I think this is where the plugin concept can catch up on the end. Like I would like to see it as a bbPress replacement but I think this will not work out of the box. Although it would be awesome ;-) |
Also we should truncate the slug at 40 characters or so. |
What needs to be done:
|
The field 80 characters for the title - it's VERY, very little to complete the work: - / |
@balancer I was referring to the size of the database column, but that is currently set to 200. |
It may as well be set to 255, 200 is kind of arbitrary. The max title length should be configurable (not necessarily via default UI, but definitely via db settings). Do we have an issue for that elsewhere or should we reopen this one? |
I created an issue, thanks. |
There should be a smaller limit on the length of a discussion title (60 characters?)
The text was updated successfully, but these errors were encountered: