Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When searching for something with few characters doesn't throw error. #368

Open
dav-is opened this issue Feb 5, 2016 · 9 comments
Open

Comments

@dav-is
Copy link

dav-is commented Feb 5, 2016

When searching for 'a' or 'my' or 'few' it says, 'It looks like there are no discussions here.' instead of 'You must input more than 5 characters' (for example).

example of bug

@franzliedke
Copy link

The exact example from the screenshot is working for me, so I am closing this.

@dav-is
Copy link
Author

dav-is commented Dec 7, 2019

@dsevillamartin
Copy link
Member

I think this issue was more for some error showing that you need 3 characters minimum for searches.

@franzliedke
Copy link

Hmm, this might very quickly become driver-dependent (especially as we're planning to make the search backend more pluggable).

I'll leave this closed and cross-reference it in flarum/framework#596.

@askvortsov1
Copy link
Member

Reopening as per flarum/framework#596 (comment). This is very far from a priority (and as Franz noted, something that might not be relevant with search drivers), but it'd be nice to have a record of it for now.

@stale
Copy link

stale bot commented Oct 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

@stale stale bot added the stale label Oct 26, 2020
@stale
Copy link

stale bot commented Nov 26, 2020

We are closing this issue as it seems to have grown stale. If you still encounter this problem with the latest version, feel free to re-open it.

@stale stale bot closed this as completed Nov 26, 2020
@askvortsov1
Copy link
Member

askvortsov1 commented Nov 26, 2020

Not quite stale. After flarum/framework#2456, we might want to add an error message (other than no discussions found) if the length is too small.

@askvortsov1 askvortsov1 reopened this Nov 26, 2020
@stale stale bot removed the stale label Nov 26, 2020
@askvortsov1
Copy link
Member

The remaining issue here is to add a different error message for empty results in IndexPage IF the q param is not empty (IE we are currently on the search results of a page), and shorter than the min search length.

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/issue-archive Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/issue-archive Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/issue-archive Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/issue-archive Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/issue-archive Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/issue-archive Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/issue-archive Mar 10, 2022
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
@SychO9 SychO9 removed this from Roadmap May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants