-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flaky Test] os/kola/aws, arm: cl.ignition.{v2,v1}.btrfsroot #621
Comments
This issue is related: coreos/fedora-coreos-tracker#920. |
This test also fails on equinix metal analysis shows the following:
this blocks the boot, waiting at emergency shell phase for 5 minutes.
Ignition has this nice comment right before udev settle that nicely explains that this kind of thing is unlikely but can happen: https://github.com/flatcar-linux/ignition/blob/flatcar-master/internal/exec/stages/disks/disks.go#L92-L115. |
Yeah, these kind of races are common when modifying block devices. A udev settle means really nothing and only a proper waiter can tell whether the condition we wait for is reached or not. |
One way out here would be a waiter directly after the mkfs call which checks that the new filesystem is up under /dev/disk/by-uuid/VALUE based on the expected new UUID. Another solution is to issue a tagged udev event when all mkfs actions are done and wait for it to be reported back, meaning the event queue got completely processed up to this point. |
I think it should work to replace the |
Tried my luck here: flatcar/ignition#35 |
Please reopen if you see this race again |
Which tests are flaking?
Description
The test flakes on AWS-ARM and passes on subsequent runs. In the #618 release, the test has not passed even after a couple of runs in Beta but passed on Stable. On Alpha,
cl.ignition.v2.btrfsroot
on the second run, but the other test kept failing.Log from the tests (if any)
The instance freezes after throwing the given log in the console
The text was updated successfully, but these errors were encountered: