Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC Redirect not working #650

Closed
anas-zurkiyeh-sp opened this issue May 18, 2023 · 1 comment
Closed

OIDC Redirect not working #650

anas-zurkiyeh-sp opened this issue May 18, 2023 · 1 comment

Comments

@anas-zurkiyeh-sp
Copy link

Description

While trying to configure OICD with Azure AD in the cloud, I encountered an issue where the redirect URL is always invalid. Nebraska does not seem to be updating the value for the callback URL from AD and I'm always getting http://localhost:8000/login?login_redirect_url=<NEBRASKA_URL> where <NEBRASKA_URL> is nebraska's custom domain. I was able to replicate this behavior locally by passing the -oidc-valid-redirect-urls flag and it seems to not take in any value as I'm always redirected to the URL http://localhost:8000/login?login_redirect_url=http://localhost:8000/

Impact

Unable to configure OIDC with Azure ID as an identity provider.

Environment and steps to reproduce

I will describe how to replicate locally:

./nebraska -auth-mode oidc -http-static-dir ./static/ \
-http-log -enable-syncer \
-oidc-client-id <CLIENT_ID> \
-oidc-issuer-url https:/
/login.microsoftonline.com/<TENANT_ID>/v2.0 \
-oidc-client-secret <CLIENT_SECRET> \
-oidc-admin-roles nebraska_admin \
-oidc-viewer-roles nebraska_member \
-oidc-valid-redirect-urls <NEBRASKA_DOMAIN>

I noticed that regardless of the value of <Nebraska_DOMAIN>, it does not seem to be change the behavior.

Trying to navigate to <Nebraska_DOMAIN> always results in http://localhost:8000/login?login_redirect_url=<NEBRASAKA_DOMAIN>/

Expected behavior

Expected to redirect to specified URL passed in by the flag -oidc-valid-redirect-urls

@anas-zurkiyeh-sp anas-zurkiyeh-sp closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2023
@anas-zurkiyeh-sp
Copy link
Author

Passing in -nebraska-url fixed issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant