Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing Docs Broken Link #849

Closed
anistark opened this issue Sep 29, 2024 · 2 comments · Fixed by flatcar/flatcar-website#363
Closed

Contributing Docs Broken Link #849

anistark opened this issue Sep 29, 2024 · 2 comments · Fixed by flatcar/flatcar-website#363

Comments

@anistark
Copy link

Description

The contributing link on development page points to https://www.flatcar.org/docs/latest/nebraska/development/contributing which doesn't exist.
Probably awaiting newdocs branch merge.

Impact

Low impact. Contributing page shows 404.

Environment and steps to reproduce

  1. Set-up: Any Browser
  2. Task: Recreating 404 page.
  3. Action(s):
    a. Visit development page.
    b. Click on contributing link.
  4. Error: 404 page

Expected behavior

Should show contributing page.

@dongsupark
Copy link
Member

Thanks for reporting the issue.

Indeed the link is broken.
However, the newdocs branch was written 4 years ago, so it is not possible to directly merge the branch.
I will try to manually copy certain files from the branch to create a new PR.

@dongsupark
Copy link
Member

Hmm, actually the text in contributing.md in newdocs branch is already included in the development page.
Will simply remove the contributing link from the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants