coreos-cloudinit: fix hostname reset bug #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
approved these changes
Jan 15, 2024
|
http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/3274/cldsv/ Will merge/backport as soon as tests finish. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/7542355987 |
Coreos-cloudinit needs to only apply a hostname if it is non-empty, otherwise the hostname ends up being "localhost". Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
coreos-cloudinit-fix-empty-hostname
branch
from
53e84cf to
892a51e
Compare
|
tested - this now works |
jepio
added a commit
that referenced
this pull request
Jan 16, 2024
coreos-cloudinit: fix hostname reset bug Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
added a commit
that referenced
this pull request
Jan 16, 2024
coreos-cloudinit: fix hostname reset bug Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coreos-cloudinit: fix hostname reset bug
When coreos-cloudinit runs on a platform where afterburn sets the hostname it would reset the hostname to localhost. Fix that bug, by checking that the hostname is non-empty before applying. Pulls in flatcar/coreos-cloudinit#25.
See: flatcar/Flatcar#1262
How to use
Boot built image on Azure without providing any userdata to see if the hostname gets reset.
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.