Fix the initrd option in the QEMU launcher script #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was -R, but this was already taken by the read-only pflash option, so use -r instead. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
krnowak
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the initrd option in the QEMU launcher script
It was
-R, but this was already taken by the read-only pflash option, so use-rinstead.How to use
Try the PXE version of the script with the
-roption. You can pass a renamed copy of flatcar_production_pxe_image.cpio.gz and check the process listing to see what was passed to QEMU.Testing done
I manually applied this change to the existing PXE script and tried the
-roption. I don't think anything in CI covers this.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.