feat(toolbox-ctr): script using ctr instead of docker #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, I suggest that we do the fallback directly inside the toolbox script. E.g., prefer |
spnngl
force-pushed
the
toolbox-ctr
branch
2 times, most recently
from
4083f48
to
26c4d31
Compare
|
Just updated with ctr support with docker fallback directly within toolbox script. |
spnngl
force-pushed
the
toolbox-ctr
branch
2 times, most recently
from
dd7c52c
to
950f8ee
Compare
pothos
reviewed
Oct 19, 2022
pothos
reviewed
Oct 19, 2022
spnngl
force-pushed
the
toolbox-ctr
branch
2 times, most recently
from
ead7e82
to
ee2289f
Compare
pothos
reviewed
Oct 26, 2022
Toolbox version using docker as principal CRI but with ctr fallback for containerd systems running without docker. Use debian:unstable-slim image as default.
pothos
approved these changes
Oct 27, 2022
|
Thanks! |
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Oct 27, 2022
This pulls in flatcar/toolbox#7 to download and mount the image with containerd instead of requiring Docker.
This was referenced Oct 27, 2022
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 17, 2023
This pulls in flatcar/toolbox#7 to download and mount the image with containerd instead of requiring Docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Toolbox version using ctr]
Toolbox version using ctr cli instead of docker for system which have only containerd and not docker daemon.
Use debian:unstable-slim image as default.
How to use
Just type
toolbox-ctr(as root) on a flatcar running containerd.Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.