Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download from URL #17

Closed
pothos opened this issue Oct 10, 2023 · 0 comments · Fixed by #29
Closed

Download from URL #17

pothos opened this issue Oct 10, 2023 · 0 comments · Fixed by #29
Assignees
Labels
kind/feature A feature request.

Comments

@pothos
Copy link
Member

pothos commented Oct 10, 2023

Currently the ue-rs download needs an XML dump, but we also need to have a mode where an URL can be passed, this is used in the Flatcar postinst hook for old update-engine clients that can't pass the XML dump and the initrd extension download phase (The match string and XML dump arguments are not required/processed then)

Flatcar integration points: flatcar/Flatcar#1028 (comment)

For example, it can be subcommands instead of exclusive arguments:

    if [ "${url}" = "" ]; then
        ue-rs-fetch payload-from-url --payload-url "${url}" --target-file "${target}" --pub-key /usr/share/update_engine/update-payload-key.pub.pem
    else
        ue-rs-fetch payload-from-xml --xml-dump "${from}" --payload-name "${name}" --target-file "${target}" --pub-key /usr/share/update_engine/update-payload-key.pub.pem
    fi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants