Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire up omaha::Hash<T> with DynDigest #31

Closed
dongsupark opened this issue Nov 24, 2023 · 2 comments · Fixed by #47
Closed

wire up omaha::Hash<T> with DynDigest #31

dongsupark opened this issue Nov 24, 2023 · 2 comments · Fixed by #47
Labels
kind/feature A feature request.

Comments

@dongsupark
Copy link
Member

Currently hash_on_disk only supports only Sha256, it simply relies on Sha256, although omaha::Hash has both Sha256 and Sha1.

For potential supports of Sha1, it might be interesting to look into digest::DynDigest of Rustcrypto that supports multiple hash functions at the same with generics.

@dongsupark dongsupark added the kind/feature A feature request. label Nov 24, 2023
@pothos
Copy link
Member

pothos commented Nov 30, 2023

It would be good to support sha1 hashes in the Omaha response and check them if available. With an old Nebraska version one only get sha1 when syncing from the public Nebraska.

@pothos
Copy link
Member

pothos commented Jan 3, 2024

Change done in #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants