Incorrect tests - limited-portals-openfile and limited-portals-savefile or bug in FileChooser interface

[SoumyaRanjanPatnaik]

Operating System

Ubuntu 23.10 (mantic)

XDG Desktop Portal version

Git

XDG Desktop Portal version (Other)

No response

Desktop Environment

wlroots

Desktop Environment (Other)

No response

Expected Behavior

limited-portals-openfile and limited-portals-savefile should pass when the default interface in limited-portals.conf is set to none.

Current Behavior

The tests should fail when the default interface in limited-portals.conf is set to none. Setting it to limited fixes it.

Steps to Reproduce

1. Apply the patch fix: fallback implementation is used if preferred value of none #1255 that fixes the behaviour of none
2. Setup the meson build directory using

   meson setup . build --prefix /usr -Dinstalled-tests=true
   

3. Run the tests

   meson test -C build
   

4. limited-portals-openfile and limited-portals-savefile should fail
5. Set default=limited in limited-portals.conf
6. Rerun the tests. They should pass now

Anything else we should know?

The previous behaviour of none was incorrect as it used the fallback interfaces. This is fixed with #1255.

My working theory is that these tests either call some other interface, requests to which were handled by the xdp-gtk fallback. Either this or there is an undiscovered bug in FileChooser. I would be happy to hunt it with some help.

Refer my comment at #1255 (comment) for more info.

[SoumyaRanjanPatnaik]

I realised that the tests were, in fact, correct. There was an issue in the PR, which caused all interfaces to be disabled when default was set to none. Silly of me to blame them the tests 😞. Closing this issue.