Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Inline date time issues with the time in multiple mode #1147

Closed
chrisbbreuer opened this issue Dec 5, 2017 · 3 comments
Closed

Bug - Inline date time issues with the time in multiple mode #1147

chrisbbreuer opened this issue Dec 5, 2017 · 3 comments

Comments

@chrisbbreuer
Copy link

If you inline flatpickr and enable the time and multi multiple mode, you will realize that it is not as intuitive changing the time and the first chosen time (earliest date) is the one that will be reactive always.

Reproduction Link

Here is an example in plain js

<input type='text' id="flatpickr" />
var fp = flatpickr(document.querySelector('#flatpickr'), {
  altFormat: "F j, Y",
  altInput: true,
  inline: true,
  enableTime: true,
  mode: "multiple",
  onChange: function(selectedDates, dateStr, instance) {
    console.log('date: ', dateStr);
  }
});

bug

http://jsfiddle.net/ankurk91/jmxcrknt/

Your Environment

  • flatpickr version used: 4.1.4
  • Browser name and version: Chrome 62.0
  • OS and version: MacOS High Sierra

ankurk91/vue-flatpickr-component#44

I would truly appreciate any help on this!

@chmln
Copy link
Member

chmln commented Dec 6, 2017

Hello,

I don't see bugs there - the time picker is not supposed to update the time on ALL dates.
If you want to update the time on ALL dates, you can hook into onChange and do so :)

@chrisbbreuer
Copy link
Author

chrisbbreuer commented Dec 6, 2017

@chmln

mainly I am commenting now to say thanks for this library and your work on it. Truly appreciate it!

Indeed, seems it is a Vue component related issue ankurk91/vue-flatpickr-component#44

ps: can't wait for the next release 👍

@chmln
Copy link
Member

chmln commented Dec 7, 2017

@Chinese1904 you're most welcome. I'm glad you found the library useful.

@chmln chmln closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants