Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PanZoom.vue #31

Open
saraedum opened this issue Oct 30, 2021 · 0 comments
Open

Cleanup PanZoom.vue #31

saraedum opened this issue Oct 30, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@saraedum
Copy link
Member

The PanZoom component has some issues at the moment. Namely,

  • the semantics of the two-way binding of the focused value are not completely clear. Setting a focus, reports back a focused box in the viewport coordinate system. When the ideal coordinate system is modified, we try to refocus on that focused box which might not be possible, see try/catch in PanZoom.vue. To make that refocusing more reasonable, we need some hacks in Viewer.vue.
  • the responsibilities of mounted/beforeDestroy and initialize/cleanup are not really clear.
  • the automatic resizing might be done in a better way. Again, the refocusing does not always work out great.

Probably, we should limit the capabilities of PanZoom quite a bit. E.g., by reworking/removing the two-way binding and by disallowing a change of coordinate system.

In any case, this needs lots of testing as this component breaks very frequently.

@saraedum saraedum added the enhancement New feature or request label Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant