Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope scheduled queries with labels #16413

Open
9 tasks
pintomi1989 opened this issue Jan 29, 2024 · 6 comments
Open
9 tasks

Scope scheduled queries with labels #16413

pintomi1989 opened this issue Jan 29, 2024 · 6 comments
Labels
~backend Backend-related issue. ~csa Issue was created by or deemed important by the Customer Solutions Architect. customer-blanco customer-sarahwu ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group story A user story defining an entire feature

Comments

@pintomi1989
Copy link
Contributor

pintomi1989 commented Jan 29, 2024 •
edited by rachaelshaw
Loading

Goal

User story
As a user adding/editing a query,
I want my scheduled query to target hosts based on labels
so that I can target a more specific set of hosts.

Context

Changes

Product

  • UI changes: Figma
  • CLI usage changes: Figma
  • REST API changes: Draft PR
    • API Error messages are in Figma
  • Outdated documentation changes: REST API docs (see draft PR)
  • Changes to paid features or tiers: Fleet Premium feature.

Engineering

  • Database schema migrations: TODO
  • Load testing: TODO

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: TODO
  • Risk level: Low / High TODO
  • Risk description: TODO

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. QA (@____): Added comment to user story confirming successful completion of QA.
@pintomi1989 pintomi1989 added customer-blanco ~feature fest Will be reviewed at next Feature Fest labels Jan 29, 2024
@noahtalerman noahtalerman changed the title Improve granularity of host targeting for scheduled queries Target for scheduled queries based on label Feb 9, 2024
@noahtalerman noahtalerman added customer-sarahwu story A user story defining an entire feature :product Product Design department (shows up on 🦢 Drafting board) and removed ~feature fest Will be reviewed at next Feature Fest labels Feb 9, 2024
@rachaelshaw rachaelshaw changed the title Target for scheduled queries based on label Schedule queries based on label Feb 19, 2024
@rachaelshaw rachaelshaw mentioned this issue Feb 27, 2024
Closed
@noahtalerman
Copy link
Member

@rachaelshaw we decided we want to purge the query report if a query's platforms, labels, or minimum osquery version change, right? (each option changes the targets)

I updated this dev note to reflect this:

Screenshot 2024-03-01 at 10 00 10 AM

@noahtalerman
Copy link
Member

@rachaelshaw heads up, I added this sentence to the dev note here to clarify the behavior when there are no matching hosts:

Screenshot 2024-03-01 at 10 02 46 AM

(Mike brought this up during "Product design check-in call"

@rachaelshaw
Copy link
Member

rachaelshaw commented Mar 1, 2024 •
edited
Loading

@rachaelshaw we decided we want to purge the query report if a query's platforms, labels, or minimum osquery version change, right? (each option changes the targets)

@noahtalerman yes; handling platforms/min version change is filed as a bug here: #17018

@rachaelshaw rachaelshaw added the #g-endpoint-ops Endpoint ops product group label Mar 6, 2024
@sharon-fdm sharon-fdm added ~frontend Frontend-related issue. ~backend Backend-related issue. labels Mar 6, 2024
@sharon-fdm
Copy link
Collaborator

Estimation:
BE:5
FE:3

@noahtalerman noahtalerman added ~feature fest Will be reviewed at next Feature Fest and removed :product Product Design department (shows up on 🦢 Drafting board) labels Apr 4, 2024
@nonpunctual nonpunctual added the ~csa Issue was created by or deemed important by the Customer Solutions Architect. label Apr 4, 2024
@noahtalerman noahtalerman removed the ~feature fest Will be reviewed at next Feature Fest label Apr 19, 2024
@rachaelshaw rachaelshaw added the ~feature fest Will be reviewed at next Feature Fest label May 14, 2024
@noahtalerman
Copy link
Member

Hey @rachaelshaw curious on why this is coming back to feature fest. Did a customer bring this up recently? Or, is it because we have some pretty much ready-to-go designs?

@rachaelshaw
Copy link
Member

@noahtalerman just brought it back because we already had it designed/estimated (not aware of any customer requests other than those tagged on the issue)

@noahtalerman noahtalerman removed the ~feature fest Will be reviewed at next Feature Fest label Jun 4, 2024
@noahtalerman noahtalerman changed the title Schedule queries based on label Scope scheduled queries with labels Jun 25, 2024
@noahtalerman noahtalerman mentioned this issue Nov 22, 2024
Open
@noahtalerman noahtalerman added Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. and removed Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
~backend Backend-related issue. ~csa Issue was created by or deemed important by the Customer Solutions Architect. customer-blanco customer-sarahwu ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group story A user story defining an entire feature
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rachaelshaw @noahtalerman @sharon-fdm @pintomi1989 @nonpunctual