Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigation drawer does not work on mobile #2084

Closed
FeodorFitsner opened this issue Nov 14, 2023 Discussed in #2070 · 4 comments
Closed

navigation drawer does not work on mobile #2084

FeodorFitsner opened this issue Nov 14, 2023 Discussed in #2070 · 4 comments
Labels
bug Something isn't working status: working on it Working on a fix for the issue
Milestone

Comments

@FeodorFitsner
Copy link
Contributor

Discussed in #2070

Originally posted by xtream-club November 11, 2023
Navigation drawer does not work on mobile. When deploying my application with serious python using navigation drawer it tells me that navigation drawer is not a flutter control and shows an error. I don't know if it hasn't been tested on android yet or what the problem is. But it seems that it does not work on mobile devices at the moment.

@FeodorFitsner FeodorFitsner added the bug Something isn't working label Nov 14, 2023
@FeodorFitsner
Copy link
Contributor Author

"Flet" mobile app must be updated and republished.

@FeodorFitsner FeodorFitsner modified the milestone: Flet v0.12.1 Nov 14, 2023
@FeodorFitsner FeodorFitsner added the status: working on it Working on a fix for the issue label Nov 14, 2023
@FeodorFitsner FeodorFitsner added this to the Flet v0.12.1 milestone Nov 16, 2023
@andrerotband
Copy link

@FeodorFitsner can I help with this subject?

Checking class Page I identified a difference between drawer and the others Offstages:

Ex: Banner:

   def show_banner(self, banner: Banner):
        self.__offstage.banner = banner
        self.__offstage.banner.open = True
        self.__offstage.update()

    async def show_banner_async(self, banner: Banner):
        self.__offstage.banner = banner
        self.__offstage.banner.open = True
        await self.__offstage.update_async()

And now Drawer:

    def show_drawer(self, drawer: NavigationDrawer):
        self.drawer = drawer
        self.drawer.open = True
        self.update()

    async def show_drawer_async(self, drawer: NavigationDrawer):
        self.drawer = drawer
        self.drawer.open = True
        await self.update_async()

Why aren't you using __offstage?

I apologize if this has already been reviewed.

Best regards!

@ndonkoHenri
Copy link
Contributor

ndonkoHenri commented Nov 19, 2023

Update the app... it works! 😄

@FeodorFitsner
Copy link
Contributor Author

Yep, and I'm working on 1.2.1 update with this fix: #2108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: working on it Working on a fix for the issue
Projects
None yet
Development

No branches or pull requests

3 participants