Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrolling controls are not able to scroll due to wrong super class call #3702

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

ndonkoHenri
Copy link
Collaborator

@ndonkoHenri ndonkoHenri commented Jul 24, 2024

Summary by Sourcery

This pull request addresses a bug in the scrolling controls by correcting the superclass call in the ScrollableControl class, ensuring proper functionality.

  • Bug Fixes:
    • Fixed an issue where scrolling controls were not functioning due to an incorrect superclass call.

Copy link
Contributor

sourcery-ai bot commented Jul 24, 2024

Reviewer's Guide by Sourcery

This pull request addresses an issue where scrolling controls were not functioning correctly due to an incorrect superclass initialization call. The change replaces 'Control.init(self)' with 'super().init()' in the constructor of the ScrollableControl class, ensuring that the superclass is properly initialized.

File-Level Changes

Files Changes
sdk/python/packages/flet-core/src/flet_core/scrollable_control.py Fixed the superclass initialization call in the ScrollableControl class constructor to ensure proper scrolling functionality.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ndonkoHenri - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@FeodorFitsner FeodorFitsner merged commit 378e3f3 into main Jul 24, 2024
3 checks passed
@ndonkoHenri ndonkoHenri deleted the fix-scrolling branch July 24, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants