Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationBarDestination set disabled does nothing #4029

Closed
1 task done
jeb192004 opened this issue Sep 21, 2024 · 0 comments · Fixed by #4073
Closed
1 task done

NavigationBarDestination set disabled does nothing #4029

jeb192004 opened this issue Sep 21, 2024 · 0 comments · Fixed by #4073
Assignees
Labels
bug Something isn't working controls

Comments

@jeb192004
Copy link

Duplicate Check

Describe the bug

setting 'disabled=False' does not disable the navigation button and not allow it to be clicked.

Code sample

Code
ft.NavigationBar(destinations=[ft.NavigationBarDestination(icon=ft.icons.MENU, selected_icon=ft.icons.VIDEOGAME_ASSET_ROUNDED, label="Menu"),
                                           ft.NavigationBarDestination(icon=ft.icons.KEYBOARD_DOUBLE_ARROW_RIGHT_ROUNDED, label="Pass"),
                                           ft.NavigationBarDestination(icon=ft.icons.PLAY_ARROW_ROUNDED,label="Play",disabled=False),
                                           ft.NavigationBarDestination(icon=ft.icons.SWAP_VERT_ROUNDED,label="Swap\nTiles",),
                                           ft.NavigationBarDestination(icon=ft.icons.ASSIGNMENT_RETURNED_OUTLINED,label="Return\n  Tiles",)
                                           ],
                            on_change=nav_bar_item_clicked,
                            bgcolor='#0D3B66',)

To reproduce

set a 'NavigationBarDestination' to disabled ft.NavigationBar(destinations=[ft.NavigationBarDestination(icon=ft.icons.MENU, selected_icon=ft.icons.VIDEOGAME_ASSET_ROUNDED, label="Menu", disabled=False), ],on_change=nav_bar_item_clicked,) and run the app and attempt to click the button

Expected behavior

i expect the button to not work. to not be clickable

Screenshots / Videos

Captures

[Upload media here]

![Screenshot from 2024-09-19 16-08-13](https://github.com/user-attachments/assets/e7045f3d-ece6-4b9d-9629-580463aad390)

Operating System

Linux

Operating system details

Fedora

Flet version

Version: 0.24.1

Regression

I'm not sure / I don't know

Suggestions

No response

Logs

No response

Additional details

No response

@ndonkoHenri ndonkoHenri added bug Something isn't working controls labels Sep 23, 2024
@ndonkoHenri ndonkoHenri self-assigned this Sep 23, 2024
@ndonkoHenri ndonkoHenri moved this from 🆕 New to 👀 In review in Flet Development Oct 1, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Flet Development Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working controls
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants