Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure at least one TFSF tangential dimension is nonzero #1847

Open
momchil-flex opened this issue Jul 22, 2024 · 2 comments
Open

Make sure at least one TFSF tangential dimension is nonzero #1847

momchil-flex opened this issue Jul 22, 2024 · 2 comments
Assignees
@QimingFlex

Comments

@momchil-flex
Copy link
Collaborator

momchil-flex commented Jul 22, 2024 •
edited
Loading

@QimingFlex could you help add a validation for this since it led to a user error.

I think the nontrivial part is that you need to look at the intersection between the simuation domain and the TFSF box. Because otherwise you could have a source that is 1D and a simulation that is e.g. 2D but their intersection is 0D.
@QimingFlex
Copy link
Contributor

I will look into it!

@QimingFlex
Copy link
Contributor

@momchil-flex TFSF already has a _volume_validator that throws an error if any dimensions equal 0. Could you elaborate more on the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QimingFlex QimingFlex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@momchil-flex @QimingFlex