Xcode 14 modernization #3
Conversation
Change minimum deployment target to 11.0
|
It provides a worse UX, previously, it would read the current shortcut, now it only says it's a button. And it would be nice to post a notification to confirm it was recorded. Do you want some help in sorting this out? |
|
Yeah, if you don't mind you'd probably be much faster at it :) |
In this way VO reads 'type shortcut' when entering recording mode. When recording is done, it will read the newly recorded shortcut.
|
I pushed some changes. There's only one thing that I can't get to work, but I feel like it's not possible:
I'd like to cancel recording, but I can't get any accessibility hook to work. The closest one is Other than that VO now reads the button as before, and it speaks the recorded shortcut. |
|
Thanks, that's still better than before. @rustle any opinions? |
| @@ -82,6 +82,8 @@ typedef NS_ENUM(NSUInteger, _SRRecorderControlButtonTag) | |||
| _SRRecorderControlMainButtonTag = 2 | |||
| }; | |||
|
|
|||
| @interface SRRecorderControl () <NSAccessibility, NSViewToolTipOwner> | |||
There was a problem hiding this comment.
It's unusual to add NSAccessibility conformance like this. What are you indicating?
There was a problem hiding this comment.
You might want NSAccessibilityButton which will populate the role for you
| @@ -422,6 +430,11 @@ - (NSString *)accessibilityLabel | |||
| return label; | |||
| } | |||
|
|
|||
| - (NSString *)accessibilityTitle | |||
There was a problem hiding this comment.
Does this duplication resolve a specific issue?
There was a problem hiding this comment.
(label is intended to be a clean replacement for title, but there have definitely been bugs historically)
There was a problem hiding this comment.
That was done in 349fa68 - IIRC VoiceOver reads the title of the button but we were only providing the label.
It results in having VO doing a better job at reading the state of the button.
|
I just noticed there's a bunch of upstream changes, taking a look at those and figuring out if we need any of this at all. I might have wasted a bunch of time by not looking there first, oops. |
|
After speaking with Doug, there's no need to stop recording mode when moving focus away from the button. This happens automatically if you navigate to a different (interactive) control. |
|
I'm going to close this in favor of Kentzo#150. Might as well get on the latest upstream version since they've modernized a lot in the last few years. Sorry that I burned up a bunch of review cycles on this! |
Can you double-check my accessibility modernization in SRRecorderControl.m?